midterm evals

did today

• if action == 'SubscribeUser' and not self.user.may.admin(page.page_name) -> self.item_name, remove unused "page" name

• remove pointless creation of Page objects at end of splitNaviLink
• theme.username() still has Page.exists() and it is wrong anyway as used there - see old code
  • you need to do that only for the own wiki (if the user homepage is local)
  • you can't check existance for remote wiki home pages
• path_breadcrumbs is internally inconsistent (local wiki links vs. interwiki links)
• splitNaviLink is internally inconsistent (url vs. link)

• fix the errors the html validator finds in the userprefs link (css_id -> class, no commas)

• wikiutil.interwiki_name

  • function name is still wrong (a function name should describe what the function does)

  • docstring is wrong
  • return values are inconsistent

  • http://hg.moinmo.in/moin/2.0-dev-jinja2-plugins-dfeher/rev/8d3ed90ff2e1 you used "interwiki" in the non-interwiki part of the function

  • still has strange try/except - needs review whether it can be called with relative item_name like /SubItem

• path_breadcrumbs is internally inconsistent (local wiki links vs. interwiki links) * path_breadcrumbs is internally inconsistent (local wiki links vs. interwiki links)
• splitNaviLink is internally inconsistent (url vs. link)
• remove _stylesheet_link method, calls to _stylesheet_link() can easily get replaced by calling href() (in stylesheets_list)
• if easily possible (== without requiring big amounts of code), generate the links in the template

• merge theme.jinja2 back into theme.__init__ (and remove theme.jinja2), make sure theme.modernized is a mini-wrapper 100% based on ThemeBase, just giving it the name "modernized"