Short description

If we use xmlrpc for uploading a bunch of pages we likely don't need an editorbackup (draft). Currently I have backup files bigger than 140MB. This increases the memory needed for a change on each process. And also the speed xmlrpc runs.

   1 diff -r 172146fe48a2 MoinMoin/xmlrpc/__init__.py
   2 --- a/MoinMoin/xmlrpc/__init__.py	Tue May 11 23:08:11 2010 +0200
   3 +++ b/MoinMoin/xmlrpc/__init__.py	Mon May 24 10:24:50 2010 +0200
   4 @@ -567,7 +567,7 @@
   5          if not self.request.user.may.write(pagename):
   6              return xmlrpclib.Fault(1, "You are not allowed to edit this page")
   7  
   8 -        page = PageEditor(self.request, pagename)
   9 +        page = PageEditor(self.request, pagename, do_editor_backup=0)
  10          try:
  11              if self.version == 2:
  12                  newtext = self._instr(pagetext)
  13 @@ -601,7 +601,7 @@
  14          # check ACLs
  15          if not (self.request.user.may.delete(pagename) and self.request.user.may.write(newpagename)):
  16              return xmlrpclib.Fault(1, "You are not allowed to rename this page")
  17 -        editor = PageEditor(self.request, pagename)
  18 +        editor = PageEditor(self.request, pagename, do_editor_backup=0)
  19  
  20          try:
  21              editor.renamePage(newpagename)
  22 @@ -629,7 +629,7 @@
  23              return xmlrpclib.Fault(1, "You are not allowed to edit this page")
  24  
  25          rev = int(self._instr(revision))
  26 -        editor = PageEditor(self.request, pagename)
  27 +        editor = PageEditor(self.request, pagename, do_editor_backup=0)
  28  
  29          try:
  30              editor.revertPage(rev)
xmlrpc.patch


CategoryFeatureRequest CategoryFeatureImplemented

MoinMoin: FeatureRequests/XMLRPC needs no editor backup (last edited 2010-05-24 08:44:29 by ReimarBauer)