Description
If a test fails with an exception, Nir's new HTML exception handler is called making the page useless for some people.
Besides that, there is another bug in the tests code which let me see the broken exception 
Example
Steps to reproduce
- Break some stuff in order to let a test fail.
run ?action=test
Details
This Wiki.
Workaround
Run the tests from the command line: make test
Discussion
We should not ship MoinMoin again with broken tests ...
The tests are broken only in the context of the test action. We should investigate that.
The problem were few tests that use a new request instance instead of _tests.request. Don't do that! (Nir slaps himself)
There is no problem with test that fail with an exception, but with tests that raise MoinMoin.error.ConfigurationError. This error is raised when you try to create a RequestCLI instance inside the tests.
- Maybe we should remove that CLI code because it does not work, does it?
- It does work for running the tests from the command line, I think the problem was creating an instance with missing data, since the error was "Can't find config instance for url 'CLI'".
Plan
- Priority:
Assigned to: NirSoffer
- Status: fixed in patches 555-556